OSDN Git Service

kbuild: detect missing include guard for exported headers
authorMasahiro Yamada <masahiroy@kernel.org>
Wed, 18 Dec 2019 15:34:21 +0000 (00:34 +0900)
committerMasahiro Yamada <masahiroy@kernel.org>
Mon, 6 Jan 2020 17:18:38 +0000 (02:18 +0900)
Adding an include guard to every header file is good practice in case
it is included multiple times.

Exported headers are compile-tested for the comprehensive sanity checks.
Let's include the same header twice. If an include guard is missing,
the header will fail to build due to redefinition of something.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
usr/include/Makefile

index 8459846..e90f5f7 100644 (file)
@@ -93,10 +93,11 @@ header-test- += asm-generic/%
 
 extra-y := $(patsubst $(obj)/%.h,%.hdrtest, $(shell find $(obj) -name '*.h' 2>/dev/null))
 
+# Include the header to detect missing include guard.
 quiet_cmd_hdrtest = HDRTEST $<
       cmd_hdrtest = \
                $(CC) $(c_flags) -S -o /dev/null -x c /dev/null \
-                       $(if $(filter-out $(header-test-), $*.h), -include $<); \
+                       $(if $(filter-out $(header-test-), $*.h), -include $< -include $<); \
                $(PERL) $(srctree)/scripts/headers_check.pl $(obj) $(SRCARCH) $<; \
                touch $@