OSDN Git Service

rtc: ds1347: convert to devm_rtc_allocate_device
authorAlexandre Belloni <alexandre.belloni@bootlin.com>
Mon, 7 Oct 2019 13:47:20 +0000 (15:47 +0200)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Mon, 7 Oct 2019 13:49:31 +0000 (15:49 +0200)
This allows further improvement of the driver.

Link: https://lore.kernel.org/r/20191007134724.15505-6-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-ds1347.c

index 763eb60..75c522c 100644 (file)
@@ -129,13 +129,13 @@ static int ds1347_probe(struct spi_device *spi)
        data = data & 0x1B;
        regmap_write(map, DS1347_STATUS_REG, data);
 
-       rtc = devm_rtc_device_register(&spi->dev, "ds1347",
-                               &ds1347_rtc_ops, THIS_MODULE);
-
+       rtc = devm_rtc_allocate_device(&spi->dev);
        if (IS_ERR(rtc))
                return PTR_ERR(rtc);
 
-       return 0;
+       rtc->ops = &ds1347_rtc_ops;
+
+       return rtc_register_device(rtc);
 }
 
 static struct spi_driver ds1347_driver = {