OSDN Git Service

regmap: lzo: Switch to bitmap_zalloc()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 17 Jun 2019 11:54:03 +0000 (14:54 +0300)
committerMark Brown <broonie@kernel.org>
Mon, 17 Jun 2019 14:18:44 +0000 (15:18 +0100)
Switch to bitmap_zalloc() to show clearly what we are allocating.
Besides that it returns pointer of bitmap type instead of opaque void *.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/base/regmap/regcache-lzo.c

index fc14e8b..7886303 100644 (file)
@@ -148,20 +148,18 @@ static int regcache_lzo_init(struct regmap *map)
         * that register.
         */
        bmp_size = map->num_reg_defaults_raw;
-       sync_bmp = kmalloc_array(BITS_TO_LONGS(bmp_size), sizeof(long),
-                                GFP_KERNEL);
+       sync_bmp = bitmap_zalloc(bmp_size, GFP_KERNEL);
        if (!sync_bmp) {
                ret = -ENOMEM;
                goto err;
        }
-       bitmap_zero(sync_bmp, bmp_size);
 
        /* allocate the lzo blocks and initialize them */
        for (i = 0; i < blkcount; i++) {
                lzo_blocks[i] = kzalloc(sizeof **lzo_blocks,
                                        GFP_KERNEL);
                if (!lzo_blocks[i]) {
-                       kfree(sync_bmp);
+                       bitmap_free(sync_bmp);
                        ret = -ENOMEM;
                        goto err;
                }
@@ -213,7 +211,7 @@ static int regcache_lzo_exit(struct regmap *map)
         * only once.
         */
        if (lzo_blocks[0])
-               kfree(lzo_blocks[0]->sync_bmp);
+               bitmap_free(lzo_blocks[0]->sync_bmp);
        for (i = 0; i < blkcount; i++) {
                if (lzo_blocks[i]) {
                        kfree(lzo_blocks[i]->wmem);