OSDN Git Service

gobex: Fix dead assignments in gobex-header.c
authorSzymon Janc <szymon@janc.net.pl>
Wed, 13 Jun 2012 20:49:20 +0000 (22:49 +0200)
committerMarcel Holtmann <marcel@holtmann.org>
Tue, 4 Dec 2012 21:22:06 +0000 (22:22 +0100)
Values stored are never read.

gobex/gobex-header.c

index 035725b..77dcc6e 100644 (file)
@@ -109,23 +109,23 @@ gssize g_obex_header_encode(GObexHeader *header, void *buf, gsize buf_len)
                g_assert_cmpuint(utf16_len + 3, ==, header->hlen);
                u16 = g_htons(utf16_len + 3);
                ptr = put_bytes(ptr, &u16, sizeof(u16));
-               ptr = put_bytes(ptr, utf16, utf16_len);
+               put_bytes(ptr, utf16, utf16_len);
                g_free(utf16);
                break;
        case G_OBEX_HDR_ENC_BYTES:
                u16 = g_htons(header->hlen);
                ptr = put_bytes(ptr, &u16, sizeof(u16));
                if (header->extdata)
-                       ptr = put_bytes(ptr, header->v.extdata, header->vlen);
+                       put_bytes(ptr, header->v.extdata, header->vlen);
                else
-                       ptr = put_bytes(ptr, header->v.data, header->vlen);
+                       put_bytes(ptr, header->v.data, header->vlen);
                break;
        case G_OBEX_HDR_ENC_UINT8:
                *ptr = header->v.u8;
                break;
        case G_OBEX_HDR_ENC_UINT32:
                u32 = g_htonl(header->v.u32);
-               ptr = put_bytes(ptr, &u32, sizeof(u32));
+               put_bytes(ptr, &u32, sizeof(u32));
                break;
        default:
                g_assert_not_reached();
@@ -263,7 +263,7 @@ GObexHeader *g_obex_header_decode(const void *data, gsize len,
                }
                header->vlen = 4;
                header->hlen = 5;
-               ptr = get_bytes(&header->v.u32, ptr, sizeof(header->v.u32));
+               get_bytes(&header->v.u32, ptr, sizeof(header->v.u32));
                header->v.u32 = g_ntohl(header->v.u32);
                *parsed = 5;
                break;