OSDN Git Service

net: dsa: microchip: ksz8: move all DSA configurations to one location
authorOleksij Rempel <o.rempel@pengutronix.de>
Mon, 5 Dec 2022 05:22:32 +0000 (06:22 +0100)
committerPaolo Abeni <pabeni@redhat.com>
Wed, 7 Dec 2022 10:57:58 +0000 (11:57 +0100)
To make the code more comparable to KSZ9477 code, move DSA
configurations to the same location.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Acked-by: Arun Ramadoss <arun.ramadoss@microchip.com>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/dsa/microchip/ksz8795.c

index 060e41b..003b0ac 100644 (file)
@@ -1359,6 +1359,16 @@ int ksz8_setup(struct dsa_switch *ds)
 
        ds->mtu_enforcement_ingress = true;
 
+       /* We rely on software untagging on the CPU port, so that we
+        * can support both tagged and untagged VLANs
+        */
+       ds->untag_bridge_pvid = true;
+
+       /* VLAN filtering is partly controlled by the global VLAN
+        * Enable flag
+        */
+       ds->vlan_filtering_is_global = true;
+
        ksz_cfg(dev, S_REPLACE_VID_CTRL, SW_FLOW_CTRL, true);
 
        /* Enable automatic fast aging when link changed detected. */
@@ -1418,16 +1428,6 @@ int ksz8_switch_init(struct ksz_device *dev)
        dev->phy_port_cnt = dev->info->port_cnt - 1;
        dev->port_mask = (BIT(dev->phy_port_cnt) - 1) | dev->info->cpu_ports;
 
-       /* We rely on software untagging on the CPU port, so that we
-        * can support both tagged and untagged VLANs
-        */
-       dev->ds->untag_bridge_pvid = true;
-
-       /* VLAN filtering is partly controlled by the global VLAN
-        * Enable flag
-        */
-       dev->ds->vlan_filtering_is_global = true;
-
        return 0;
 }