OSDN Git Service

phy: qcom-qmp-combo: drop redundant clock allocation
authorJohan Hovold <johan+linaro@kernel.org>
Mon, 21 Nov 2022 08:50:50 +0000 (09:50 +0100)
committerVinod Koul <vkoul@kernel.org>
Thu, 24 Nov 2022 17:21:51 +0000 (22:51 +0530)
Since the QMP driver split, there is no reason to allocate the
fixed-rate pipe clock structure separately from the driver data.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Link: https://lore.kernel.org/r/20221121085058.31213-8-johan+linaro@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/qualcomm/phy-qcom-qmp-combo.c

index ebfefec..9b945a7 100644 (file)
@@ -895,6 +895,7 @@ struct qmp_combo {
        unsigned int dp_aux_cfg;
        struct phy_configure_opts_dp dp_opts;
 
+       struct clk_fixed_rate pipe_clk_fixed;
        struct clk_hw dp_link_hw;
        struct clk_hw dp_pixel_hw;
 };
@@ -2239,15 +2240,11 @@ static void phy_clk_release_provider(void *res)
  */
 static int phy_pipe_clk_register(struct qmp_combo *qmp, struct device_node *np)
 {
-       struct clk_fixed_rate *fixed;
+       struct clk_fixed_rate *fixed = &qmp->pipe_clk_fixed;
        struct clk_init_data init = { };
        char name[64];
        int ret;
 
-       fixed = devm_kzalloc(qmp->dev, sizeof(*fixed), GFP_KERNEL);
-       if (!fixed)
-               return -ENOMEM;
-
        snprintf(name, sizeof(name), "%s::pipe_clk", dev_name(qmp->dev));
        init.name = name;
        init.ops = &clk_fixed_rate_ops;