net/smc: improve smc_lgr_cleanup()

smc_lgr_cleanup() is called during termination processing, there is no
need to send a DELETE_LINK at that time. A DELETE_LINK should have been
sent before the termination is initiated, if needed.
And remove the extra call to wake_up(&lnk->wr_reg_wait) because
smc_llc_link_inactive() already calls the related helper function
smc_wr_wakeup_reg_wait().

Signed-off-by: Karsten Graul <kgraul@linux.ibm.com>
Signed-off-by: Ursula Braun <ubraun@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/smc/smc_core.c b/net/smc/smc_core.c
index 2249de5..8f3c1fc 100644 (file)
--- a/net/smc/smc_core.c
+++ b/net/smc/smc_core.c
@@ -576,11 +576,8 @@ static void smc_lgr_cleanup(struct smc_link_group *lgr)
        } else {
                struct smc_link *lnk = &lgr->lnk[SMC_SINGLE_LINK];
 
-               wake_up(&lnk->wr_reg_wait);
-               if (lnk->state != SMC_LNK_INACTIVE) {
-                       smc_link_send_delete(lnk, false);
+               if (lnk->state != SMC_LNK_INACTIVE)
                        smc_llc_link_inactive(lnk);
-               }
        }
 }