accel/habanalabs: add missing error flow in hl_sysfs_init()

hl_sysfs_fini() is called only if hl_sysfs_init() completes
successfully. Therefore if hl_sysfs_init() fails, need to remove any
sysfs group that was added until that point.

Signed-off-by: Tomer Tayar <ttayar@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>

diff --git a/drivers/accel/habanalabs/common/sysfs.c b/drivers/accel/habanalabs/common/sysfs.c
index 735d8be..01f89f0 100644 (file)
--- a/drivers/accel/habanalabs/common/sysfs.c
+++ b/drivers/accel/habanalabs/common/sysfs.c
@@ -497,10 +497,14 @@ int hl_sysfs_init(struct hl_device *hdev)
        if (rc) {
                dev_err(hdev->dev,
                        "Failed to add groups to device, error %d\n", rc);
-               return rc;
+               goto remove_groups;
        }
 
        return 0;
+
+remove_groups:
+       device_remove_groups(hdev->dev, hl_dev_attr_groups);
+       return rc;
 }
 
 void hl_sysfs_fini(struct hl_device *hdev)