OSDN Git Service

drm/tinydrm: Fix doc build warnings
authorNoralf Trønnes <noralf@tronnes.org>
Tue, 10 Jul 2018 15:05:18 +0000 (17:05 +0200)
committerNoralf Trønnes <noralf@tronnes.org>
Wed, 11 Jul 2018 20:24:02 +0000 (22:24 +0200)
include/drm/tinydrm/tinydrm.h:34: warning: Function parameter or member 'fb_dirty' not described in 'tinydrm_device'
drivers/gpu/drm/tinydrm/mipi-dbi.c:272: warning: Function parameter or member 'crtc_state' not described in 'mipi_dbi_enable_flush'
drivers/gpu/drm/tinydrm/mipi-dbi.c:272: warning: Function parameter or member 'plane_state' not described in 'mipi_dbi_enable_flush'

Move struct member docs inline so it's not missed next time.

Cc: David Lechner <david@lechnology.com>
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
Reviewed-by: David Lechner <david@lechnology.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180710150518.10528-1-noralf@tronnes.org
drivers/gpu/drm/tinydrm/mipi-dbi.c
include/drm/tinydrm/tinydrm.h

index 4d1fb31..cb3441e 100644 (file)
@@ -260,6 +260,8 @@ static const struct drm_framebuffer_funcs mipi_dbi_fb_funcs = {
 /**
  * mipi_dbi_enable_flush - MIPI DBI enable helper
  * @mipi: MIPI DBI structure
+ * @crtc_state: CRTC state
+ * @plane_state: Plane state
  *
  * This function sets &mipi_dbi->enabled, flushes the whole framebuffer and
  * enables the backlight. Drivers can use this in their
index 56e4a91..fe9827d 100644 (file)
 
 /**
  * struct tinydrm_device - tinydrm device
- * @drm: DRM device
- * @pipe: Display pipe structure
- * @dirty_lock: Serializes framebuffer flushing
- * @fb_funcs: Framebuffer functions used when creating framebuffers
  */
 struct tinydrm_device {
+       /**
+        * @drm: DRM device
+        */
        struct drm_device *drm;
+
+       /**
+        * @pipe: Display pipe structure
+        */
        struct drm_simple_display_pipe pipe;
+
+       /**
+        * @dirty_lock: Serializes framebuffer flushing
+        */
        struct mutex dirty_lock;
+
+       /**
+        * @fb_funcs: Framebuffer functions used when creating framebuffers
+        */
        const struct drm_framebuffer_funcs *fb_funcs;
+
+       /**
+        * @fb_dirty: Framebuffer dirty callback
+        */
        int (*fb_dirty)(struct drm_framebuffer *framebuffer,
                        struct drm_file *file_priv, unsigned flags,
                        unsigned color, struct drm_clip_rect *clips,