OSDN Git Service

net: neigh: add skb drop reasons to arp_error_report()
authorMenglong Dong <imagedong@tencent.com>
Sat, 26 Feb 2022 04:18:31 +0000 (12:18 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 26 Feb 2022 12:53:59 +0000 (12:53 +0000)
When neighbour become invalid or destroyed, neigh_invalidate() will be
called. neigh->ops->error_report() will be called if the neighbour's
state is NUD_FAILED, and seems here is the only use of error_report().
So we can tell that the reason of skb drops in arp_error_report() is
SKB_DROP_REASON_NEIGH_FAILED.

Replace kfree_skb() used in arp_error_report() with kfree_skb_reason().

Reviewed-by: Mengen Sun <mengensun@tencent.com>
Reviewed-by: Hao Peng <flyingpeng@tencent.com>
Signed-off-by: Menglong Dong <imagedong@tencent.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/arp.c

index dc28f05..2d0c05c 100644 (file)
@@ -293,7 +293,7 @@ static int arp_constructor(struct neighbour *neigh)
 static void arp_error_report(struct neighbour *neigh, struct sk_buff *skb)
 {
        dst_link_failure(skb);
-       kfree_skb(skb);
+       kfree_skb_reason(skb, SKB_DROP_REASON_NEIGH_FAILED);
 }
 
 /* Create and send an arp packet. */