OSDN Git Service

net: lan966x: Remove .ndo_change_rx_flags
authorHoratiu Vultur <horatiu.vultur@microchip.com>
Sat, 18 Dec 2021 21:49:42 +0000 (22:49 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 20 Dec 2021 11:44:05 +0000 (11:44 +0000)
The function lan966x_port_change_rx_flags() was used only when
IFF_PROMISC flag was set. In that case it was setting to copy all the
frames to the CPU instead of removing any RX filters. Therefore remove
it.

Fixes: d28d6d2e37d10d ("net: lan966x: add port module support")
Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/microchip/lan966x/lan966x_main.c

index 7c6d629..dc40ac2 100644 (file)
@@ -298,28 +298,6 @@ static int lan966x_port_xmit(struct sk_buff *skb, struct net_device *dev)
        return lan966x_port_ifh_xmit(skb, ifh, dev);
 }
 
-static void lan966x_set_promisc(struct lan966x_port *port, bool enable)
-{
-       struct lan966x *lan966x = port->lan966x;
-
-       lan_rmw(ANA_CPU_FWD_CFG_SRC_COPY_ENA_SET(enable),
-               ANA_CPU_FWD_CFG_SRC_COPY_ENA,
-               lan966x, ANA_CPU_FWD_CFG(port->chip_port));
-}
-
-static void lan966x_port_change_rx_flags(struct net_device *dev, int flags)
-{
-       struct lan966x_port *port = netdev_priv(dev);
-
-       if (!(flags & IFF_PROMISC))
-               return;
-
-       if (dev->flags & IFF_PROMISC)
-               lan966x_set_promisc(port, true);
-       else
-               lan966x_set_promisc(port, false);
-}
-
 static int lan966x_port_change_mtu(struct net_device *dev, int new_mtu)
 {
        struct lan966x_port *port = netdev_priv(dev);
@@ -369,7 +347,6 @@ static const struct net_device_ops lan966x_port_netdev_ops = {
        .ndo_open                       = lan966x_port_open,
        .ndo_stop                       = lan966x_port_stop,
        .ndo_start_xmit                 = lan966x_port_xmit,
-       .ndo_change_rx_flags            = lan966x_port_change_rx_flags,
        .ndo_change_mtu                 = lan966x_port_change_mtu,
        .ndo_set_rx_mode                = lan966x_port_set_rx_mode,
        .ndo_get_phys_port_name         = lan966x_port_get_phys_port_name,