OSDN Git Service

crypto: inside-secure - unmap the result in the hash send error path
authorAntoine Tenart <antoine.tenart@bootlin.com>
Tue, 13 Feb 2018 08:26:57 +0000 (09:26 +0100)
committerHerbert Xu <herbert@gondor.apana.org.au>
Thu, 22 Feb 2018 14:16:28 +0000 (22:16 +0800)
This patch adds a label to unmap the result buffer in the hash send
function error path.

Fixes: 1b44c5a60c13 ("crypto: inside-secure - add SafeXcel EIP197 crypto engine driver")
Suggested-by: Ofer Heifetz <oferh@marvell.com>
Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/inside-secure/safexcel_hash.c

index 43e94cd..a4960a9 100644 (file)
@@ -303,7 +303,7 @@ send_command:
                                   req->state_sz);
        if (IS_ERR(rdesc)) {
                ret = PTR_ERR(rdesc);
-               goto cdesc_rollback;
+               goto unmap_result;
        }
 
        spin_unlock_bh(&priv->ring[ring].egress_lock);
@@ -315,6 +315,8 @@ send_command:
        *results = 1;
        return 0;
 
+unmap_result:
+       dma_unmap_sg(priv->dev, areq->src, req->nents, DMA_TO_DEVICE);
 cdesc_rollback:
        for (i = 0; i < n_cdesc; i++)
                safexcel_ring_rollback_wptr(priv, &priv->ring[ring].cdr);