OSDN Git Service

Renamed HIDL SensorManager::mManager -> mInternalManager.
authorYifan Hong <elsk@google.com>
Wed, 29 Mar 2017 00:21:21 +0000 (17:21 -0700)
committerYifan Hong <elsk@google.com>
Mon, 3 Apr 2017 19:25:24 +0000 (12:25 -0700)
Use "Internal" to represent objects of the wrapped type.

Test: pass
Change-Id: I4f86bc2c7c272c9abb0c5b4c2837baccfdc2a748

services/sensorservice/hidl/SensorManager.cpp
services/sensorservice/hidl/include/sensorservicehidl/SensorManager.h

index 37e53dc..576fcb5 100644 (file)
@@ -36,14 +36,14 @@ using ::android::hardware::Void;
 using ::android::sp;
 
 SensorManager::SensorManager()
-        : mManager{::android::SensorManager::getInstanceForPackage(
+        : mInternalManager{::android::SensorManager::getInstanceForPackage(
             String16(ISensorManager::descriptor))} {
 }
 
 // Methods from ::android::frameworks::sensorservice::V1_0::ISensorManager follow.
 Return<void> SensorManager::getSensorList(getSensorList_cb _hidl_cb) {
     ::android::Sensor const* const* list;
-    ssize_t count = mManager.getSensorList(&list);
+    ssize_t count = mInternalManager.getSensorList(&list);
     if (count < 0 || !list) {
         LOG(ERROR) << "::android::SensorManager::getSensorList encounters " << count;
         _hidl_cb({}, Result::UNKNOWN_ERROR);
@@ -59,7 +59,7 @@ Return<void> SensorManager::getSensorList(getSensorList_cb _hidl_cb) {
 }
 
 Return<void> SensorManager::getDefaultSensor(SensorType type, getDefaultSensor_cb _hidl_cb) {
-    ::android::Sensor const* sensor = mManager.getDefaultSensor(static_cast<int>(type));
+    ::android::Sensor const* sensor = mInternalManager.getDefaultSensor(static_cast<int>(type));
     if (!sensor) {
         _hidl_cb({}, Result::NOT_EXIST);
         return Void();
@@ -95,7 +95,7 @@ Return<void> SensorManager::createAshmemDirectChannel(
         return Void();
     }
 
-    createDirectChannel(mManager, size, SENSOR_DIRECT_MEM_TYPE_ASHMEM,
+    createDirectChannel(mInternalManager, size, SENSOR_DIRECT_MEM_TYPE_ASHMEM,
             mem.handle(), _hidl_cb);
 
     return Void();
@@ -105,7 +105,7 @@ Return<void> SensorManager::createGrallocDirectChannel(
         const hidl_handle& buffer, uint64_t size,
         createGrallocDirectChannel_cb _hidl_cb) {
 
-    createDirectChannel(mManager, size, SENSOR_DIRECT_MEM_TYPE_GRALLOC,
+    createDirectChannel(mInternalManager, size, SENSOR_DIRECT_MEM_TYPE_GRALLOC,
             buffer.getNativeHandle(), _hidl_cb);
 
     return Void();
index 0b026c9..4d70b2d 100644 (file)
@@ -45,7 +45,7 @@ struct SensorManager : public ISensorManager {
     Return<void> createGrallocDirectChannel(const hidl_handle& buffer, uint64_t size, createGrallocDirectChannel_cb _hidl_cb) override;
     Return<void> createEventQueue(const sp<IEventQueueCallback> &callback, createEventQueue_cb _hidl_cb);
 private:
-    ::android::SensorManager& mManager;
+    ::android::SensorManager& mInternalManager;
 
 };