OSDN Git Service

ASoC: sprd: Switch to use list_entry_is_head() helper
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 8 Dec 2020 11:18:05 +0000 (13:18 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 28 Dec 2020 12:24:45 +0000 (12:24 +0000)
Since we got list_entry_is_head() helper in the generic header,
we may switch driver to use it. This eliminates the need
in additional variable.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20201208111805.6989-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sprd/sprd-mcdt.c

index f439e55..34b2ce7 100644 (file)
@@ -866,23 +866,23 @@ EXPORT_SYMBOL_GPL(sprd_mcdt_chan_dma_disable);
 struct sprd_mcdt_chan *sprd_mcdt_request_chan(u8 channel,
                                              enum sprd_mcdt_channel_type type)
 {
-       struct sprd_mcdt_chan *temp, *chan = NULL;
+       struct sprd_mcdt_chan *temp;
 
        mutex_lock(&sprd_mcdt_list_mutex);
 
        list_for_each_entry(temp, &sprd_mcdt_chan_list, list) {
                if (temp->type == type && temp->id == channel) {
-                       chan = temp;
+                       list_del_init(&temp->list);
                        break;
                }
        }
 
-       if (chan)
-               list_del(&chan->list);
+       if (list_entry_is_head(temp, &sprd_mcdt_chan_list, list))
+               temp = NULL;
 
        mutex_unlock(&sprd_mcdt_list_mutex);
 
-       return chan;
+       return temp;
 }
 EXPORT_SYMBOL_GPL(sprd_mcdt_request_chan);