OSDN Git Service

mpegvideo_parser: avoid signed overflow in bitrate calculation
authorAnton Khirnov <anton@khirnov.net>
Sat, 17 Dec 2016 14:07:51 +0000 (15:07 +0100)
committerAnton Khirnov <anton@khirnov.net>
Mon, 19 Dec 2016 07:15:07 +0000 (08:15 +0100)
CC: libav-stable@libav.org
Bug-Id: 981
Found-By: Agostino Sarubbo
libavcodec/mpegvideo_parser.c

index 27f2985..500d124 100644 (file)
@@ -97,7 +97,14 @@ static void mpegvideo_extract_headers(AVCodecParserContext *s,
 
                         pc->width  |=(horiz_size_ext << 12);
                         pc->height |=( vert_size_ext << 12);
-                        avctx->bit_rate += (bit_rate_ext << 18) * 400;
+
+                        bit_rate_ext <<= 18;
+                        if (bit_rate_ext < INT_MAX / 400 &&
+                            bit_rate_ext * 400 < INT_MAX - avctx->bit_rate) {
+                            avctx->bit_rate += bit_rate_ext * 400;
+                        } else
+                            avctx->bit_rate = 0;
+
                         if(did_set_size)
                             ff_set_dimensions(avctx, pc->width, pc->height);
                         avctx->framerate.num = pc->frame_rate.num * (frame_rate_ext_n + 1) * 2;