OSDN Git Service

[media] sn9c102: Replace memcpy with struct assignment
authorEzequiel Garcia <elezegarcia@gmail.com>
Tue, 23 Oct 2012 18:57:07 +0000 (15:57 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Thu, 27 Dec 2012 20:44:46 +0000 (18:44 -0200)
This kind of memcpy() is error-prone. Its replacement with a struct
assignment is prefered because it's type-safe and much easier to read.
Found by coccinelle. Hand patched and reviewed.
Tested by compilation only.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier struct_name;
struct struct_name to;
struct struct_name from;
expression E;
@@
-memcpy(&(to), &(from), E);
+to = from;
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/usb/sn9c102/sn9c102_core.c

index 6bda81a..c957e9a 100644 (file)
@@ -2827,7 +2827,7 @@ sn9c102_vidioc_querybuf(struct sn9c102_device* cam, void __user * arg)
            b.index >= cam->nbuffers || cam->io != IO_MMAP)
                return -EINVAL;
 
-       memcpy(&b, &cam->frame[b.index].buf, sizeof(b));
+       b = cam->frame[b.index].buf;
 
        if (cam->frame[b.index].vma_use_count)
                b.flags |= V4L2_BUF_FLAG_MAPPED;
@@ -2930,7 +2930,7 @@ sn9c102_vidioc_dqbuf(struct sn9c102_device* cam, struct file* filp,
 
        f->state = F_UNUSED;
 
-       memcpy(&b, &f->buf, sizeof(b));
+       b = f->buf;
        if (f->vma_use_count)
                b.flags |= V4L2_BUF_FLAG_MAPPED;