OSDN Git Service

virtio: console: remove unnecessary null test before debugfs_remove_recursive
authorFabian Frederick <fabf@skynet.be>
Sat, 26 Jul 2014 22:00:01 +0000 (07:30 +0930)
committerRusty Russell <rusty@rustcorp.com.au>
Sun, 27 Jul 2014 11:37:14 +0000 (21:07 +0930)
Fix checkpatch warning:
WARNING: debugfs_remove_recursive(NULL) is safe this check is probably not required

Cc: Arnd Bergmann <arnd@arndb.de>
Cc: virtualization@lists.linux-foundation.org
Reviewed-by: Amit Shah <amit.shah@redhat.com>
Signed-off-by: Fabian Frederick <fabf@skynet.be>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
drivers/char/virtio_console.c

index 60aafb8..b585b47 100644 (file)
@@ -2262,8 +2262,7 @@ static int __init init(void)
 unregister:
        unregister_virtio_driver(&virtio_console);
 free:
-       if (pdrvdata.debugfs_dir)
-               debugfs_remove_recursive(pdrvdata.debugfs_dir);
+       debugfs_remove_recursive(pdrvdata.debugfs_dir);
        class_destroy(pdrvdata.class);
        return err;
 }
@@ -2276,8 +2275,7 @@ static void __exit fini(void)
        unregister_virtio_driver(&virtio_rproc_serial);
 
        class_destroy(pdrvdata.class);
-       if (pdrvdata.debugfs_dir)
-               debugfs_remove_recursive(pdrvdata.debugfs_dir);
+       debugfs_remove_recursive(pdrvdata.debugfs_dir);
 }
 module_init(init);
 module_exit(fini);