OSDN Git Service

staging: bcm2835-audio: don't initialize memory twice
authorNicolas Saenz Julienne <nsaenzjulienne@suse.de>
Wed, 17 Oct 2018 19:01:51 +0000 (21:01 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 7 Nov 2018 11:38:15 +0000 (12:38 +0100)
The memory is being allocated with devres_alloc(), wich ultimately uses
__GFP_ZERO to call kmalloc. We don't need to zero the memory area again
in bcm2835-audio.

Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/bcm2835-audio/bcm2835.c

index 87d56ab..0efae70 100644 (file)
@@ -39,8 +39,6 @@ static int bcm2835_devm_add_vchi_ctx(struct device *dev)
        if (!vchi_ctx)
                return -ENOMEM;
 
-       memset(vchi_ctx, 0, sizeof(*vchi_ctx));
-
        ret = bcm2835_new_vchi_ctx(dev, vchi_ctx);
        if (ret) {
                devres_free(vchi_ctx);