OSDN Git Service
(root)
/
uclinux-h8
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
bbae615
)
media: imon: Fix null-ptr-deref in imon_probe
author
Arvind Yadav
<arvind.yadav.cs@gmail.com>
Mon, 9 Oct 2017 18:14:48 +0000
(20:14 +0200)
committer
Mauro Carvalho Chehab
<mchehab@osg.samsung.com>
Fri, 27 Oct 2017 15:36:25 +0000
(17:36 +0200)
It seems that the return value of usb_ifnum_to_if() can be NULL and
needs to be checked.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Tested-by: Andrey Konovalov <andreyknvl@google.com>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/rc/imon.c
patch
|
blob
|
history
diff --git
a/drivers/media/rc/imon.c
b/drivers/media/rc/imon.c
index
9724fe8
..
9fef8cc
100644
(file)
--- a/
drivers/media/rc/imon.c
+++ b/
drivers/media/rc/imon.c
@@
-2515,6
+2515,11
@@
static int imon_probe(struct usb_interface *interface,
mutex_lock(&driver_lock);
first_if = usb_ifnum_to_if(usbdev, 0);
+ if (!first_if) {
+ ret = -ENODEV;
+ goto fail;
+ }
+
first_if_ctx = usb_get_intfdata(first_if);
if (ifnum == 0) {