OSDN Git Service

drm/i915/gvt: Fix an error code in ppgtt_populate_spt_by_guest_entry()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 13 May 2019 09:22:44 +0000 (12:22 +0300)
committerZhenyu Wang <zhenyuw@linux.intel.com>
Tue, 21 May 2019 02:58:16 +0000 (10:58 +0800)
"ret" is uninitialized on this path but it should be -EINVAL.

Fixes: 930c8dfea4b8 ("drm/i915/gvt: Check if get_next_pt_type() always returns a valid value")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
drivers/gpu/drm/i915/gvt/gtt.c

index 08c74e6..244ad17 100644 (file)
@@ -1076,8 +1076,10 @@ static struct intel_vgpu_ppgtt_spt *ppgtt_populate_spt_by_guest_entry(
        } else {
                int type = get_next_pt_type(we->type);
 
-               if (!gtt_type_is_pt(type))
+               if (!gtt_type_is_pt(type)) {
+                       ret = -EINVAL;
                        goto err;
+               }
 
                spt = ppgtt_alloc_spt_gfn(vgpu, type, ops->get_pfn(we), ips);
                if (IS_ERR(spt)) {