OSDN Git Service

media: gspca: make array st6422_bridge_init static, makes object smaller
authorColin Ian King <colin.king@canonical.com>
Mon, 7 Oct 2019 10:18:48 +0000 (07:18 -0300)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Thu, 10 Oct 2019 10:21:46 +0000 (07:21 -0300)
Don't populate the array st6422_bridge_init on the stack but instead
make it static. Makes the object code smaller by 231 bytes.

Before:
   text    data     bss     dec     hex filename
   3419     752      64    4235    108b gspca/stv06xx/stv06xx_st6422.o

After:
   text    data     bss     dec     hex filename
   3124     816      64    4004     fa4 gspca/stv06xx/stv06xx_st6422.o

(gcc version 9.2.1, amd64)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/usb/gspca/stv06xx/stv06xx_st6422.c

index 7104a88..aac19d4 100644 (file)
@@ -117,7 +117,7 @@ static int st6422_init(struct sd *sd)
 {
        int err = 0, i;
 
-       const u16 st6422_bridge_init[][2] = {
+       static const u16 st6422_bridge_init[][2] = {
                { STV_ISO_ENABLE, 0x00 }, /* disable capture */
                { 0x1436, 0x00 },
                { 0x1432, 0x03 },       /* 0x00-0x1F brightness */