OSDN Git Service

dma: mmp_pdma: Fix physical channel memory allocation size
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Tue, 15 Apr 2014 15:13:35 +0000 (17:13 +0200)
committerVinod Koul <vinod.koul@intel.com>
Fri, 2 May 2014 15:49:07 +0000 (21:19 +0530)
Use sizeof(*var) instead of sizeof(type) when calling devm_k*alloc().
This avoids using the wrong type as was done to allocate the physical
channels array.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/mmp_pdma.c

index f3fe92d..7affa53 100644 (file)
@@ -858,8 +858,7 @@ static int mmp_pdma_chan_init(struct mmp_pdma_device *pdev, int idx, int irq)
        struct mmp_pdma_chan *chan;
        int ret;
 
-       chan = devm_kzalloc(pdev->dev, sizeof(struct mmp_pdma_chan),
-                           GFP_KERNEL);
+       chan = devm_kzalloc(pdev->dev, sizeof(*chan), GFP_KERNEL);
        if (chan == NULL)
                return -ENOMEM;
 
@@ -946,8 +945,7 @@ static int mmp_pdma_probe(struct platform_device *op)
                        irq_num++;
        }
 
-       pdev->phy = devm_kcalloc(pdev->dev,
-                                dma_channels, sizeof(struct mmp_pdma_chan),
+       pdev->phy = devm_kcalloc(pdev->dev, dma_channels, sizeof(*pdev->phy),
                                 GFP_KERNEL);
        if (pdev->phy == NULL)
                return -ENOMEM;