Avoid initializeRecorder during onPause.

When on-screen setting is visible and home key is pressed,
onPause will set mSetting to invisible and initializeRecorder()
will be called in onVisibilityChanged(). That will cause exception
if surface holder is still null.
bug 2319111

diff --git a/src/com/android/camera/VideoCamera.java b/src/com/android/camera/VideoCamera.java
index bc7bca1..b3ddb19 100644 (file)
--- a/src/com/android/camera/VideoCamera.java
+++ b/src/com/android/camera/VideoCamera.java
@@ -1087,7 +1087,9 @@ public class VideoCamera extends NoSearchActivity
             releaseMediaRecorder();
             mPreferences.registerOnSharedPreferenceChangeListener(this);
         } else {
-            initializeRecorder();
+            // When mSetting is set to invisible in onPause, we should not
+            // initialize recorder.
+            if (!mPausing) initializeRecorder();
             mPreferences.unregisterOnSharedPreferenceChangeListener(this);
         }
     }