RDMA/mlx5: Fix query_srq_cmd() function

The output buffer used in mlx5_cmd_exec_inout() was wrongly changed from
pre-allocated srq_out pointer to an input "out" point. That leads to
unpredictable results in the get_srqc() call later.

Fixes: 31578defe4eb ("RDMA/mlx5: Update mlx5_ib to use new cmd interface")
Link: https://lore.kernel.org/r/20200513100809.246315-1-leon@kernel.org
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

diff --git a/drivers/infiniband/hw/mlx5/srq_cmd.c b/drivers/infiniband/hw/mlx5/srq_cmd.c
index bc50a71..6f5eadc 100644 (file)
--- a/drivers/infiniband/hw/mlx5/srq_cmd.c
+++ b/drivers/infiniband/hw/mlx5/srq_cmd.c
@@ -169,16 +169,16 @@ static int query_srq_cmd(struct mlx5_ib_dev *dev, struct mlx5_core_srq *srq,
 
        MLX5_SET(query_srq_in, in, opcode, MLX5_CMD_OP_QUERY_SRQ);
        MLX5_SET(query_srq_in, in, srqn, srq->srqn);
-       err = mlx5_cmd_exec_inout(dev->mdev, query_srq, in, out);
+       err = mlx5_cmd_exec_inout(dev->mdev, query_srq, in, srq_out);
        if (err)
                goto out;
 
-       srqc = MLX5_ADDR_OF(query_srq_out, out, srq_context_entry);
+       srqc = MLX5_ADDR_OF(query_srq_out, srq_out, srq_context_entry);
        get_srqc(srqc, out);
        if (MLX5_GET(srqc, srqc, state) != MLX5_SRQC_STATE_GOOD)
                out->flags |= MLX5_SRQ_FLAG_ERR;
 out:
-       kvfree(out);
+       kvfree(srq_out);
        return err;
 }