OSDN Git Service

wifi: cfg80211: use strscpy to replace strlcpy
authorXueBing Chen <chenxuebing@jari.cn>
Mon, 11 Jul 2022 14:27:58 +0000 (22:27 +0800)
committerJohannes Berg <johannes.berg@intel.com>
Fri, 15 Jul 2022 09:43:12 +0000 (11:43 +0200)
The strlcpy should not be used because it doesn't limit the source
length. Preferred is strscpy.

Signed-off-by: XueBing Chen <chenxuebing@jari.cn>
Link: https://lore.kernel.org/r/2d2fcbf7.e33.181eda8e70e.Coremail.chenxuebing@jari.cn
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/wireless/ethtool.c

index 24e1840..2613d6a 100644 (file)
@@ -10,20 +10,20 @@ void cfg80211_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
        struct device *pdev = wiphy_dev(wdev->wiphy);
 
        if (pdev->driver)
-               strlcpy(info->driver, pdev->driver->name,
+               strscpy(info->driver, pdev->driver->name,
                        sizeof(info->driver));
        else
-               strlcpy(info->driver, "N/A", sizeof(info->driver));
+               strscpy(info->driver, "N/A", sizeof(info->driver));
 
-       strlcpy(info->version, init_utsname()->release, sizeof(info->version));
+       strscpy(info->version, init_utsname()->release, sizeof(info->version));
 
        if (wdev->wiphy->fw_version[0])
-               strlcpy(info->fw_version, wdev->wiphy->fw_version,
+               strscpy(info->fw_version, wdev->wiphy->fw_version,
                        sizeof(info->fw_version));
        else
-               strlcpy(info->fw_version, "N/A", sizeof(info->fw_version));
+               strscpy(info->fw_version, "N/A", sizeof(info->fw_version));
 
-       strlcpy(info->bus_info, dev_name(wiphy_dev(wdev->wiphy)),
+       strscpy(info->bus_info, dev_name(wiphy_dev(wdev->wiphy)),
                sizeof(info->bus_info));
 }
 EXPORT_SYMBOL(cfg80211_get_drvinfo);