OSDN Git Service

ALSA: sound/ppc: Use bitwise instead of arithmetic operator for flags
authorSamuel Zou <zou_wei@huawei.com>
Thu, 7 May 2020 03:54:07 +0000 (11:54 +0800)
committerTakashi Iwai <tiwai@suse.de>
Thu, 7 May 2020 07:06:11 +0000 (09:06 +0200)
Fix the following coccinelle warnings:

sound/ppc/pmac.c:729:57-58: WARNING: sum of probable bitmasks, consider |
sound/ppc/pmac.c:229:37-38: WARNING: sum of probable bitmasks, consider |

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Samuel Zou <zou_wei@huawei.com>
Link: https://lore.kernel.org/r/1588823647-12480-1-git-send-email-zou_wei@huawei.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/ppc/pmac.c

index 592532c..2e750b3 100644 (file)
@@ -226,7 +226,7 @@ static int snd_pmac_pcm_prepare(struct snd_pmac *chip, struct pmac_stream *rec,
                offset += rec->period_size;
        }
        /* make loop */
-       cp->command = cpu_to_le16(DBDMA_NOP + BR_ALWAYS);
+       cp->command = cpu_to_le16(DBDMA_NOP | BR_ALWAYS);
        cp->cmd_dep = cpu_to_le32(rec->cmd.addr);
 
        snd_pmac_dma_stop(rec);
@@ -726,7 +726,7 @@ void snd_pmac_beep_dma_start(struct snd_pmac *chip, int bytes, unsigned long add
        chip->extra_dma.cmds->xfer_status = cpu_to_le16(0);
        chip->extra_dma.cmds->cmd_dep = cpu_to_le32(chip->extra_dma.addr);
        chip->extra_dma.cmds->phy_addr = cpu_to_le32(addr);
-       chip->extra_dma.cmds->command = cpu_to_le16(OUTPUT_MORE + BR_ALWAYS);
+       chip->extra_dma.cmds->command = cpu_to_le16(OUTPUT_MORE | BR_ALWAYS);
        out_le32(&chip->awacs->control,
                 (in_le32(&chip->awacs->control) & ~0x1f00)
                 | (speed << 8));