OSDN Git Service

Staging: sm750fb: Remove zero testing pointer typed value
authorAmitoj Kaur Chawla <amitoj1606@gmail.com>
Thu, 2 Apr 2015 17:31:04 +0000 (23:01 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 3 Apr 2015 09:10:27 +0000 (11:10 +0200)
Removes variable comparison with 0.
Done using following coccinelle script.

@ disable is_zero,isnt_zero @
expression *E;
expression E1,f;
@@

E = f(...)
<...
(
- E == 0
+ !E
|
- E != 0
+ E
|
- 0 == E
+ !E
|
- 0 != E
+ E
)
...>
?E = E1

@ disable is_zero,isnt_zero @
expression *E;
@@

(
  E ==
- 0
+ NULL
|
  E !=
- 0
+ NULL
|
- 0
+ NULL
  == E
|
- 0
+ NULL
  != E
)

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/sm750fb/ddk750_chip.c

index cd1508a..9b5bb7e 100644 (file)
@@ -110,7 +110,7 @@ void setChipClock(unsigned int frequency)
                return;
 #endif
 
-       if (frequency != 0) {
+       if (frequency) {
                /*
                * Set up PLL, a structure to hold the value to be set in clocks.
                */
@@ -139,7 +139,7 @@ void setMemoryClock(unsigned int frequency)
        if (getChipType() == SM750LE)
                return;
 #endif
-       if (frequency != 0) {
+       if (frequency) {
                /* Set the frequency to the maximum frequency that the DDR Memory can take
                which is 336MHz. */
                if (frequency > MHz(336))
@@ -187,7 +187,7 @@ void setMasterClock(unsigned int frequency)
        if (getChipType() == SM750LE)
                return;
 #endif
-       if (frequency != 0) {
+       if (frequency) {
                /* Set the frequency to the maximum frequency that the SM750 engine can
                run, which is about 190 MHz. */
                if (frequency > MHz(190))