OSDN Git Service

crypto: stm32-hash - Simplify with dev_err_probe()
authorKrzysztof Kozlowski <krzk@kernel.org>
Thu, 10 Sep 2020 19:29:18 +0000 (21:29 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 18 Sep 2020 07:20:12 +0000 (17:20 +1000)
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and the error value gets printed.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/stm32/stm32-hash.c

index e84330f..e3e2527 100644 (file)
@@ -1464,14 +1464,9 @@ static int stm32_hash_probe(struct platform_device *pdev)
        }
 
        hdev->clk = devm_clk_get(&pdev->dev, NULL);
-       if (IS_ERR(hdev->clk)) {
-               if (PTR_ERR(hdev->clk) != -EPROBE_DEFER) {
-                       dev_err(dev, "failed to get clock for hash (%lu)\n",
-                               PTR_ERR(hdev->clk));
-               }
-
-               return PTR_ERR(hdev->clk);
-       }
+       if (IS_ERR(hdev->clk))
+               return dev_err_probe(dev, PTR_ERR(hdev->clk),
+                                    "failed to get clock for hash\n");
 
        ret = clk_prepare_enable(hdev->clk);
        if (ret) {