OSDN Git Service

drm/i915/gt: Initialise rps timestamp
authorChris Wilson <chris@chris-wilson.co.uk>
Fri, 19 Jun 2020 15:19:38 +0000 (16:19 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Fri, 19 Jun 2020 19:00:18 +0000 (20:00 +0100)
Smatch warns that we may iterate over an empty array of gt->engines[].
One hopes that this is impossible, but nevertheless we can simply
appease smatch by initialising the timestamp to zero before we starting
probing the busy-time from the engines.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200619151938.21740-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/gt/intel_rps.c

index bdece93..296391d 100644 (file)
@@ -51,10 +51,11 @@ static void rps_timer(struct timer_list *t)
 {
        struct intel_rps *rps = from_timer(rps, t, timer);
        struct intel_engine_cs *engine;
+       ktime_t dt, last, timestamp;
        enum intel_engine_id id;
        s64 max_busy[3] = {};
-       ktime_t dt, timestamp, last;
 
+       timestamp = 0;
        for_each_engine(engine, rps_to_gt(rps), id) {
                s64 busy;
                int i;
@@ -69,7 +70,6 @@ static void rps_timer(struct timer_list *t)
                                swap(busy, max_busy[i]);
                }
        }
-
        last = rps->pm_timestamp;
        rps->pm_timestamp = timestamp;