OSDN Git Service

drivers: net: xgene: Fix the order of the arguments of 'alloc_etherdev_mqs()'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 26 Jan 2020 10:44:29 +0000 (11:44 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 27 Jan 2020 10:23:13 +0000 (11:23 +0100)
'alloc_etherdev_mqs()' expects first 'tx', then 'rx'. The semantic here
looks reversed.

Reorder the arguments passed to 'alloc_etherdev_mqs()' in order to keep
the correct semantic.

In fact, this is a no-op because both XGENE_NUM_[RT]X_RING are 8.

Fixes: 107dec2749fe ("drivers: net: xgene: Add support for multiple queues")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/apm/xgene/xgene_enet_main.c

index e284b67..6aee2f0 100644 (file)
@@ -2020,7 +2020,7 @@ static int xgene_enet_probe(struct platform_device *pdev)
        int ret;
 
        ndev = alloc_etherdev_mqs(sizeof(struct xgene_enet_pdata),
-                                 XGENE_NUM_RX_RING, XGENE_NUM_TX_RING);
+                                 XGENE_NUM_TX_RING, XGENE_NUM_RX_RING);
        if (!ndev)
                return -ENOMEM;