[modify]人気ランキングのページから該当スコアランキングへのリンクを貼る

diff --git a/db_common.inc b/db_common.inc
index 0ef9fdb..f15e53d 100644 (file)
--- a/db_common.inc
+++ b/db_common.inc
@@ -247,13 +247,10 @@ EOM
         $stat = [];
 
         $this->dbh->beginTransaction();
-        $stmt = $this->dbh->query("SELECT race_name AS name, * from race_statistics NATURAL INNER JOIN races ORDER BY total_count DESC");
-        $stat['race'] = $stmt->fetchAll(PDO::FETCH_ASSOC);
-        $stmt = $this->dbh->query("SELECT class_name AS name, * from class_statistics NATURAL INNER JOIN classes ORDER BY total_count DESC");
-        $stat['class'] = $stmt->fetchAll(PDO::FETCH_ASSOC);
-        $stmt = $this->dbh->query("SELECT personality_name AS name, * from personality_statistics NATURAL INNER JOIN personalities ORDER BY total_count DESC");
-        $stat['personality'] = $stmt->fetchAll(PDO::FETCH_ASSOC);
-
+        foreach ([['race', 'races'], ['class', 'classes'], ['personality', 'personalities']] as $kind) {
+            $stmt = $this->dbh->query("SELECT ${kind[0]}_id AS id, ${kind[0]}_name AS name, * FROM ${kind[0]}_statistics NATURAL JOIN ${kind[1]} ORDER BY total_count DESC");
+            $stat[$kind[0]] = $stmt->fetchAll(PDO::FETCH_ASSOC);
+        }
         $this->dbh->commit();
 
         return $stat;

diff --git a/popularity_ranking.php b/popularity_ranking.php
index bd75859..2a82f89 100644 (file)
--- a/popularity_ranking.php
+++ b/popularity_ranking.php
@@ -8,37 +8,39 @@ ini_set('zlib.output_compression', 'On');
 
 include "db_common.inc";
 
-function print_popularity_table($stat, $name)
+function print_popularity_table($stat, $id_name, $name)
 {
-    echo <<< EOM
-        <table>
-    <tr>
-    <th>#
-    <th>$name
-    <th>計
-    <th>男性
-    <th>女性
-    <th>勝利
-    <th>平均スコア
-    <th>最大スコア
-    </tr>
+    echo <<<EOM
+<table>
+<tr>
+<th>#</th>
+<th>$name</th>
+<th>計</th>
+<th>男性</th>
+<th>女性</th>
+<th>勝利</th>
+<th>平均スコア</th>
+<th>最大スコア</th>
+</tr>
+
 EOM;
 
     $rank = 0;
-    foreach ($stat as $s) {
+    foreach ($stat as $k => $s) {
         $rank ++;
+        $name_link = "<a href='score_ranking.php?{$id_name}={$s['id']}'>{$s['name']}</a></td>";
         $average_score = floor($s['average_score']);
-        echo <<< EOM
+        echo <<<EOM
 <tr>
-            <td>$rank</td>
-        <td>{$s['name']}</td>
-        <td>{$s['total_count']}</td>
-        <td>{$s['male_count']}</td>
-        <td>{$s['female_count']}</td>
-        <td>{$s['winner_count']}</td>
-        <td>$average_score</td>
-        <td>{$s['max_score']}</td>
-        </tr>
+<td>$rank</td>
+<td>$name_link</td>
+<td>{$s['total_count']}</td>
+<td>{$s['male_count']}</td>
+<td>{$s['female_count']}</td>
+<td>{$s['winner_count']}</td>
+<td>$average_score</td>
+<td>{$s['max_score']}</td>
+</tr>
 EOM;
     }
 
@@ -63,24 +65,28 @@ $query_time = microtime(true) - $time_start;
 <title>変愚蛮怒 人気のある種族・職業・性格</title>
 </head>
 
-<small>クエリ時間<?php echo sprintf("%.3f msec", $query_time * 1000) ?></small>
+<small>
+<?php
+echo sprintf("(%.2f 秒)", $query_time);
+?>
+</small>
 <hr>
 <h1>人気のある種族</h1>
 
 <?php
-print_popularity_table($statistics['race'], "種族");
+print_popularity_table($statistics['race'], 'race_id', "種族");
 ?>
 
 <hr>
 <h1>人気のある職業</h1>
 
 <?php
-print_popularity_table($statistics['class'], "職業");
+print_popularity_table($statistics['class'], 'class_id', "職業");
 ?>
 
 <hr>
 <h1>人気のある性格</h1>
 
 <?php
-print_popularity_table($statistics['personality'], "性格");
+print_popularity_table($statistics['personality'], 'personality_id', "性格");
 ?>