OSDN Git Service
(root)
/
uclinux-h8
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
181d444
)
can: bittiming: can_validate_bitrate(): simplify bit rate checking
author
Marc Kleine-Budde
<mkl@pengutronix.de>
Thu, 19 Dec 2019 09:17:37 +0000
(10:17 +0100)
committer
Marc Kleine-Budde
<mkl@pengutronix.de>
Thu, 24 Feb 2022 07:26:03 +0000
(08:26 +0100)
This patch simplifies the validation of the fixed bit rates. If a
supported bit rate is found, directly return 0.
If no valid bit rate is found return -EINVAL;
Link:
https://lore.kernel.org/all/20220124215642.3474154-6-mkl@pengutronix.de
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/dev/bittiming.c
patch
|
blob
|
history
diff --git
a/drivers/net/can/dev/bittiming.c
b/drivers/net/can/dev/bittiming.c
index
d5fca3b
..
1b1d149
100644
(file)
--- a/
drivers/net/can/dev/bittiming.c
+++ b/
drivers/net/can/dev/bittiming.c
@@
-248,18
+248,14
@@
can_validate_bitrate(struct net_device *dev, struct can_bittiming *bt,
const u32 *bitrate_const,
const unsigned int bitrate_const_cnt)
{
- struct can_priv *priv = netdev_priv(dev);
unsigned int i;
for (i = 0; i < bitrate_const_cnt; i++) {
if (bt->bitrate == bitrate_const[i])
-
break
;
+
return 0
;
}
- if (i >= priv->bitrate_const_cnt)
- return -EINVAL;
-
- return 0;
+ return -EINVAL;
}
int can_get_bittiming(struct net_device *dev, struct can_bittiming *bt,