OSDN Git Service

RDMA/cma: Set default GID type as RoCE when resolving RoCE route
authorParav Pandit <parav@mellanox.com>
Tue, 14 Nov 2017 12:52:00 +0000 (14:52 +0200)
committerJason Gunthorpe <jgg@mellanox.com>
Mon, 18 Dec 2017 22:37:06 +0000 (15:37 -0700)
As the function name suggests cma_resolve_iboe_route() resolves RoCE
route. However, its default GID type is IB_GID_TYPE_IB and not
IB_GID_TYPE_ROCE, even though both are mapped to the same enum value.
Change default GID type to IB_GID_TYPE_ROCE.

cma_iboe_set_mgid() is updated to reflect the RoCEv2 GID check.

Signed-off-by: Parav Pandit <parav@mellanox.com>
Reviewed-by: Daniel Jurgens <danielj@mellanox.com>
Reviewed-by: Noa Osherovich <noaos@mellanox.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/core/cma.c

index 9841e7c..e63a51b 100644 (file)
@@ -2528,7 +2528,7 @@ static int cma_resolve_iboe_route(struct rdma_id_private *id_priv)
        struct cma_work *work;
        int ret;
        struct net_device *ndev = NULL;
-       enum ib_gid_type gid_type = IB_GID_TYPE_IB;
+       enum ib_gid_type gid_type = IB_GID_TYPE_ROCE;
        u8 default_roce_tos = id_priv->cma_dev->default_roce_tos[id_priv->id.port_num -
                                        rdma_start_port(id_priv->cma_dev->device)];
        u8 tos = id_priv->tos_set ? id_priv->tos : default_roce_tos;
@@ -4009,8 +4009,10 @@ static void cma_iboe_set_mgid(struct sockaddr *addr, union ib_gid *mgid,
        } else if (addr->sa_family == AF_INET6) {
                memcpy(mgid, &sin6->sin6_addr, sizeof *mgid);
        } else {
-               mgid->raw[0] = (gid_type == IB_GID_TYPE_IB) ? 0xff : 0;
-               mgid->raw[1] = (gid_type == IB_GID_TYPE_IB) ? 0x0e : 0;
+               mgid->raw[0] =
+                       (gid_type == IB_GID_TYPE_ROCE_UDP_ENCAP) ? 0 : 0xff;
+               mgid->raw[1] =
+                       (gid_type == IB_GID_TYPE_ROCE_UDP_ENCAP) ? 0 : 0x0e;
                mgid->raw[2] = 0;
                mgid->raw[3] = 0;
                mgid->raw[4] = 0;