OSDN Git Service

media: imx-jpeg: Fix the error handling path of 'mxc_jpeg_probe()'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sat, 21 Aug 2021 11:12:53 +0000 (13:12 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 30 Sep 2021 08:07:55 +0000 (10:07 +0200)
A successful 'mxc_jpeg_attach_pm_domains()' call should be balanced by a
corresponding 'mxc_jpeg_detach_pm_domains()' call in the error handling
path of the probe, as already done in the remove function.

Update the error handling path accordingly.

Fixes: 2db16c6ed72c ("media: imx-jpeg: Add V4L2 driver for i.MX8 JPEG Encoder/Decoder")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/imx-jpeg/mxc-jpeg.c

index b3cc519..73e73b6 100644 (file)
@@ -2086,6 +2086,8 @@ err_m2m:
        v4l2_device_unregister(&jpeg->v4l2_dev);
 
 err_register:
+       mxc_jpeg_detach_pm_domains(jpeg);
+
 err_irq:
        return ret;
 }