2002-12-05 Martin M. Hunt <hunt@redhat.com>

	* library/regwin.itb (update): Revert previous patch to this
	function. But also don't tag blank cells.
	(_but3): Fix help call.

diff --git a/gdb/gdbtk/ChangeLog b/gdb/gdbtk/ChangeLog
index 2dffc03..c36e41a 100644 (file)
--- a/gdb/gdbtk/ChangeLog
+++ b/gdb/gdbtk/ChangeLog
@@ -1,5 +1,17 @@
+2002-12-05  Martin M. Hunt  <hunt@redhat.com>
+
+       * library/regwin.itb (update): Revert previous patch to this
+       function. But also don't tag blank cells.
+       (_but3): Fix help call.
+
 2002-12-04  Martin M. Hunt  <hunt@redhat.com>
 
+       * library/regwin.itb (_but3): Fix help call. 
+
+       * library/helpviewer.tcl (open_help): Fix KDE apps list.
+
+       * library/debugwin.itb (build_win): Fix help call.
+       
        * library/regwin.itb (update): Remove some old code
        that marked registers as changed when the target started.
        (_build_win): Make changed registers more visible by

diff --git a/gdb/gdbtk/library/regwin.itb b/gdb/gdbtk/library/regwin.itb
index 3099ec4..29518db 100644 (file)
--- a/gdb/gdbtk/library/regwin.itb
+++ b/gdb/gdbtk/library/regwin.itb
@@ -635,8 +635,7 @@ itcl::body RegWin::_but3 {x y X Y} {
       # Help
       $itk_component(popup) add separator
       $itk_component(popup) add command    \
-       -label "Help" \
-       -command {ManagedWin::open HtmlViewer -force -file register.html}
+       -label "Help" -command {open_help register.html}
 
       tk_popup $itk_component(popup) $X $Y
     }
@@ -1122,17 +1121,31 @@ itcl::body RegWin::update {event} {
     set _change_list $changed
   }
 
+  # Problem: if the register was invalid (i.e, we were not running),
+  # its old value will probably be "0x0". Now if we run and its real
+  # value is "0x0", then it will appear as a blank in the register
+  # window. Safegaurd against that here by adding any such register
+  # which is not already in the change list.
+  foreach r $_reg_display_list {
+    if {$_data($_cell($r)) == "" && [lsearch $_change_list $r] == -1} {
+      lappend _change_list $r
+    }
+  }
+
   # Tag the changed cells and resize the columns
   set cols {}
   foreach r $_change_list {
     _update_register $r
-    $itk_component(table) tag cell highlight $_cell($r)
+
+    if {$_data($_cell($r)) != ""} {
+      $itk_component(table) tag cell highlight $_cell($r)
+    }
     set col [lindex [split $_cell($r) ,] 1]
     if {[lsearch $cols $col] == -1} {
       lappend cols $col
     }
   }
-
+  
   foreach col $cols {
     set col [string trim $col ()]
     _size_column $col 0