OSDN Git Service

drm/amd/display: off by one in find_irq_source_info()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 4 Jul 2018 09:46:15 +0000 (12:46 +0300)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 5 Jul 2018 21:40:02 +0000 (16:40 -0500)
The ->info[] array has DAL_IRQ_SOURCES_NUMBER elements so this condition
should be >= instead of > or we could read one element beyond the end of
the array.

Fixes: 4562236b3bc0 ("drm/amd/dc: Add dc display driver (v2)")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/irq/irq_service.c

index dcdfa0f..604bea0 100644 (file)
@@ -78,7 +78,7 @@ const struct irq_source_info *find_irq_source_info(
        struct irq_service *irq_service,
        enum dc_irq_source source)
 {
-       if (source > DAL_IRQ_SOURCES_NUMBER || source < DC_IRQ_SOURCE_INVALID)
+       if (source >= DAL_IRQ_SOURCES_NUMBER || source < DC_IRQ_SOURCE_INVALID)
                return NULL;
 
        return &irq_service->info[source];