OSDN Git Service
(root)
/
tomoyo
/
tomoyo-test1.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
ec4a1d9
)
phy: rockchip-inno-usb2: Fix missing clk_disable_unprepare() in rockchip_usb2phy_powe...
author
Shang XiaoJing
<shangxiaojing@huawei.com>
Mon, 5 Dec 2022 11:58:23 +0000
(19:58 +0800)
committer
Vinod Koul
<vkoul@kernel.org>
Fri, 13 Jan 2023 17:40:52 +0000
(23:10 +0530)
The clk_disable_unprepare() should be called in the error handling of
rockchip_usb2phy_power_on().
Fixes:
0e08d2a727e6
("phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy")
Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
Link:
https://lore.kernel.org/r/20221205115823.16957-1-shangxiaojing@huawei.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/rockchip/phy-rockchip-inno-usb2.c
patch
|
blob
|
history
diff --git
a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
index
e6ededc
..
a0bc10a
100644
(file)
--- a/
drivers/phy/rockchip/phy-rockchip-inno-usb2.c
+++ b/
drivers/phy/rockchip/phy-rockchip-inno-usb2.c
@@
-485,8
+485,10
@@
static int rockchip_usb2phy_power_on(struct phy *phy)
return ret;
ret = property_enable(base, &rport->port_cfg->phy_sus, false);
- if (ret)
+ if (ret) {
+ clk_disable_unprepare(rphy->clk480m);
return ret;
+ }
/* waiting for the utmi_clk to become stable */
usleep_range(1500, 2000);