OSDN Git Service

mwifiex: pcie: Remove a couple of unchecked 'ret's
authorLee Jones <lee.jones@linaro.org>
Mon, 2 Nov 2020 11:24:00 +0000 (11:24 +0000)
committerKalle Valo <kvalo@codeaurora.org>
Sat, 7 Nov 2020 16:05:37 +0000 (18:05 +0200)
Fixes the following W=1 kernel build warning(s):

 drivers/net/wireless/marvell/mwifiex/pcie.c: In function ‘mwifiex_pcie_remove’:
 drivers/net/wireless/marvell/mwifiex/pcie.c:432:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
 drivers/net/wireless/marvell/mwifiex/pcie.c: In function ‘mwifiex_cleanup_pcie’:
 drivers/net/wireless/marvell/mwifiex/pcie.c:3142:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]

Cc: Amitkumar Karwar <amitkarwar@gmail.com>
Cc: Ganapathi Bhat <ganapathi.bhat@nxp.com>
Cc: Xinming Hu <huxinming820@gmail.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20201102112410.1049272-32-lee.jones@linaro.org
drivers/net/wireless/marvell/mwifiex/pcie.c

index 6a10ff0..67e0247 100644 (file)
@@ -429,7 +429,6 @@ static void mwifiex_pcie_remove(struct pci_dev *pdev)
        struct mwifiex_private *priv;
        const struct mwifiex_pcie_card_reg *reg;
        u32 fw_status;
-       int ret;
 
        card = pci_get_drvdata(pdev);
 
@@ -441,7 +440,7 @@ static void mwifiex_pcie_remove(struct pci_dev *pdev)
 
        reg = card->pcie.reg;
        if (reg)
-               ret = mwifiex_read_reg(adapter, reg->fw_status, &fw_status);
+               mwifiex_read_reg(adapter, reg->fw_status, &fw_status);
        else
                fw_status = -1;
 
@@ -3139,12 +3138,11 @@ static void mwifiex_cleanup_pcie(struct mwifiex_adapter *adapter)
        struct pcie_service_card *card = adapter->card;
        struct pci_dev *pdev = card->dev;
        const struct mwifiex_pcie_card_reg *reg = card->pcie.reg;
-       int ret;
        u32 fw_status;
 
        cancel_work_sync(&card->work);
 
-       ret = mwifiex_read_reg(adapter, reg->fw_status, &fw_status);
+       mwifiex_read_reg(adapter, reg->fw_status, &fw_status);
        if (fw_status == FIRMWARE_READY_PCIE) {
                mwifiex_dbg(adapter, INFO,
                            "Clearing driver ready signature\n");