* fhandler_tty.cc (fhandler_tty::open): Enhance comment.

diff --git a/winsup/cygwin/ChangeLog b/winsup/cygwin/ChangeLog
index 28abe9d..aae9a4a 100644 (file)
--- a/winsup/cygwin/ChangeLog
+++ b/winsup/cygwin/ChangeLog
@@ -1,3 +1,7 @@
+2005-12-13  Christopher Faylor  <cgf@timesys.com>
+
+       * fhandler_tty.cc (fhandler_tty::open): Enhance comment.
+
 2005-12-13  Corinna Vinschen  <corinna@vinschen.de>
 
        * fhandler_tty.cc (fhandler_tty::open): Close newly created window

diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
index 0e451b4..8b7c2d5 100644 (file)
--- a/winsup/cygwin/fhandler_tty.cc
+++ b/winsup/cygwin/fhandler_tty.cc
@@ -590,8 +590,16 @@ fhandler_tty_slave::open (int flags, mode_t)
         station or, strangely, characters will not be displayed in any windows
         drawn on the current screen.  We only do this if we have changed to
         a new windows station and if we had an existing windows station previously.
+        We also close the previously opened work station even though AllocConsole
+        is now "using" it.  This doesn't seem to cause any problems.
+
+        Things to watch out for if you make changes in this code:
+
+        - Flashing, black consoles showing up when you start, e.g., ssh in
+          an xterm.
+        - Non-displaying of characters in rxvt or xemacs if you start a
+          process using setsid: bash -lc "setsid rxvt".  */
 
-        Phew.  */
       h = horig = GetProcessWindowStation ();
       if (myself->ctty == -1)
         {