OSDN Git Service

Modify test to pass new project hooks
authorDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
Tue, 3 Dec 2013 10:08:00 +0000 (12:08 +0200)
committerDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
Wed, 4 Dec 2013 11:37:17 +0000 (13:37 +0200)
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
app/observers/merge_request_observer.rb
spec/observers/merge_request_observer_spec.rb

index 9e41f8c..9649219 100644 (file)
@@ -64,6 +64,8 @@ class MergeRequestObserver < ActivityObserver
   end
 
   def execute_hooks(merge_request)
-    merge_request.project.execute_hooks(merge_request.to_hook_data, :merge_request_hooks)
+    if merge_request.project
+      merge_request.project.execute_hooks(merge_request.to_hook_data, :merge_request_hooks)
+    end
   end
 end
index 3f5250a..3e5cdfa 100644 (file)
@@ -4,7 +4,7 @@ describe MergeRequestObserver do
   let(:some_user) { create :user }
   let(:assignee) { create :user }
   let(:author) { create :user }
-  let(:mr_mock) { double(:merge_request, id: 42, assignee: assignee, author: author) }
+  let(:mr_mock) { double(:merge_request, id: 42, assignee: assignee, author: author).as_null_object }
   let(:assigned_mr) { create(:merge_request, assignee: assignee, author: author, target_project: create(:project)) }
   let(:unassigned_mr) { create(:merge_request, author: author, target_project: create(:project)) }
   let(:closed_assigned_mr) { create(:closed_merge_request, assignee: assignee, author: author, target_project: create(:project)) }