OSDN Git Service

soc: qcom: socinfo: Fix an off by one in qcom_show_pmic_model()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 20 Jan 2021 09:57:55 +0000 (12:57 +0300)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Thu, 21 Jan 2021 01:54:10 +0000 (19:54 -0600)
These need to be < ARRAY_SIZE() instead of <= ARRAY_SIZE() to prevent
accessing one element beyond the end of the array.

Acked-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Fixes: e9247e2ce577 ("soc: qcom: socinfo: fix printing of pmic_model")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/YAf+o85Z9lgkq3Nw@mwanda
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
drivers/soc/qcom/socinfo.c

index f449df5..5b4ad24 100644 (file)
@@ -309,7 +309,7 @@ static int qcom_show_pmic_model(struct seq_file *seq, void *p)
        if (model < 0)
                return -EINVAL;
 
-       if (model <= ARRAY_SIZE(pmic_models) && pmic_models[model])
+       if (model < ARRAY_SIZE(pmic_models) && pmic_models[model])
                seq_printf(seq, "%s\n", pmic_models[model]);
        else
                seq_printf(seq, "unknown (%d)\n", model);