bug: default is mapped to no dithering.
default to spatial dithering based on color depth
Signed-off-by: Tony Cheng <tony.cheng@amd.com>
Reviewed-by: Tony Cheng <Tony.Cheng@amd.com>
Acked-by: Harry Wentland <Harry.Wentland@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
return;
if (option > DITHER_OPTION_MAX)
return;
- if (option == DITHER_OPTION_DEFAULT) {
- switch (stream->timing.display_color_depth) {
- case COLOR_DEPTH_666:
- stream->dither_option = DITHER_OPTION_SPATIAL6;
- break;
- case COLOR_DEPTH_888:
- stream->dither_option = DITHER_OPTION_SPATIAL8;
- break;
- case COLOR_DEPTH_101010:
- stream->dither_option = DITHER_OPTION_SPATIAL10;
- break;
- default:
- option = DITHER_OPTION_DISABLE;
- }
- } else {
- stream->dither_option = option;
- }
+
+ stream->dither_option = option;
+
resource_build_bit_depth_reduction_params(stream,
¶ms);
stream->bit_depth_params = params;
memset(fmt_bit_depth, 0, sizeof(*fmt_bit_depth));
+ if (option == DITHER_OPTION_DEFAULT) {
+ switch (stream->timing.display_color_depth) {
+ case COLOR_DEPTH_666:
+ option = DITHER_OPTION_SPATIAL6;
+ break;
+ case COLOR_DEPTH_888:
+ option = DITHER_OPTION_SPATIAL8;
+ break;
+ case COLOR_DEPTH_101010:
+ option = DITHER_OPTION_SPATIAL10;
+ break;
+ default:
+ option = DITHER_OPTION_DISABLE;
+ }
+ }
+
if (option == DITHER_OPTION_DISABLE)
return;
stream->timing.timing_3d_format != TIMING_3D_FORMAT_NONE);
-/*vbios crtc_source_selection and encoder_setup will override fmt_C*/
- if (pipe_ctx->stream->signal != SIGNAL_TYPE_EDP &&
- pipe_ctx->stream->signal != SIGNAL_TYPE_LVDS) {
- /*for embedded panel, don't override VBIOS's setting*/
- pipe_ctx->stream_res.opp->funcs->opp_program_fmt(
- pipe_ctx->stream_res.opp,
- &stream->bit_depth_params,
- &stream->clamping);
- }
+ pipe_ctx->stream_res.opp->funcs->opp_program_fmt(
+ pipe_ctx->stream_res.opp,
+ &stream->bit_depth_params,
+ &stream->clamping);
+
if (dc_is_dp_signal(pipe_ctx->stream->signal))
pipe_ctx->stream_res.stream_enc->funcs->dp_set_stream_attribute(
pipe_ctx->stream_res.stream_enc,