OSDN Git Service

x86/tdx: Fix early #VE handling
authorKirill A. Shutemov <kirill.shutemov@linux.intel.com>
Tue, 14 Jun 2022 12:01:33 +0000 (15:01 +0300)
committerDave Hansen <dave.hansen@linux.intel.com>
Wed, 15 Jun 2022 17:52:59 +0000 (10:52 -0700)
tdx_early_handle_ve() does not increment RIP after successfully
handling the exception.  That leads to infinite loop of exceptions.

Move RIP when exceptions are successfully handled.

[ dhansen: make problem statement more clear ]

Fixes: 32e72854fa5f ("x86/tdx: Port I/O: Add early boot support")
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Link: https://lkml.kernel.org/r/20220614120135.14812-2-kirill.shutemov@linux.intel.com
arch/x86/coco/tdx/tdx.c

index 03deb4d..faae53f 100644 (file)
@@ -447,13 +447,17 @@ static bool handle_io(struct pt_regs *regs, u32 exit_qual)
 __init bool tdx_early_handle_ve(struct pt_regs *regs)
 {
        struct ve_info ve;
+       bool ret;
 
        tdx_get_ve_info(&ve);
 
        if (ve.exit_reason != EXIT_REASON_IO_INSTRUCTION)
                return false;
 
-       return handle_io(regs, ve.exit_qual);
+       ret = handle_io(regs, ve.exit_qual);
+       if (ret)
+               regs->ip += ve.instr_len;
+       return ret;
 }
 
 void tdx_get_ve_info(struct ve_info *ve)