OSDN Git Service

drm: Eliminate the useless "non-RGB fb" debug message
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 18 Nov 2016 19:53:11 +0000 (21:53 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Thu, 15 Dec 2016 12:55:35 +0000 (14:55 +0200)
No point in spamming the log whenever a non-RGB fb is being
constructed. And since there's nothing to do anymore that
fb->bits_per_pixel and fb->depth are gone, we can just kill
off this entire piece of code.

Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1479498793-31021-36-git-send-email-ville.syrjala@linux.intel.com
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
drivers/gpu/drm/drm_modeset_helper.c

index 639e474..5b05185 100644 (file)
@@ -72,21 +72,10 @@ void drm_helper_mode_fill_fb_struct(struct drm_device *dev,
                                    struct drm_framebuffer *fb,
                                    const struct drm_mode_fb_cmd2 *mode_cmd)
 {
-       const struct drm_format_info *info;
        int i;
 
-       info = drm_format_info(mode_cmd->pixel_format);
-       if (!info || !info->depth) {
-               struct drm_format_name_buf format_name;
-
-               DRM_DEBUG_KMS("non-RGB pixel format %s\n",
-                             drm_get_format_name(mode_cmd->pixel_format,
-                                                 &format_name));
-       } else {
-       }
-
        fb->dev = dev;
-       fb->format = info;
+       fb->format = drm_format_info(mode_cmd->pixel_format);
        fb->width = mode_cmd->width;
        fb->height = mode_cmd->height;
        for (i = 0; i < 4; i++) {