OSDN Git Service

scsi: sd: sd_zbc: Return early in sd_zbc_check_zoned_characteristics()
authorDamien Le Moal <damien.lemoal@opensource.wdc.com>
Thu, 21 Apr 2022 18:30:19 +0000 (11:30 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 26 Apr 2022 03:23:04 +0000 (23:23 -0400)
Return early in sd_zbc_check_zoned_characteristics() for host-aware
disks. This patch does not change any functionality but makes a later patch
easier to read.

Link: https://lore.kernel.org/r/20220421183023.3462291-6-bvanassche@acm.org
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Acked-by: Douglas Gilbert <dgilbert@interlog.com>
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
[ bvanassche: extracted this change from a larger patch ]
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/sd_zbc.c

index ac557a5..c53e166 100644 (file)
@@ -592,14 +592,15 @@ static int sd_zbc_check_zoned_characteristics(struct scsi_disk *sdkp,
                sdkp->zones_optimal_open = get_unaligned_be32(&buf[8]);
                sdkp->zones_optimal_nonseq = get_unaligned_be32(&buf[12]);
                sdkp->zones_max_open = 0;
-       } else {
-               /* Host-managed */
-               sdkp->urswrz = buf[4] & 1;
-               sdkp->zones_optimal_open = 0;
-               sdkp->zones_optimal_nonseq = 0;
-               sdkp->zones_max_open = get_unaligned_be32(&buf[16]);
+               return 0;
        }
 
+       /* Host-managed */
+       sdkp->urswrz = buf[4] & 1;
+       sdkp->zones_optimal_open = 0;
+       sdkp->zones_optimal_nonseq = 0;
+       sdkp->zones_max_open = get_unaligned_be32(&buf[16]);
+
        /*
         * Check for unconstrained reads: host-managed devices with
         * constrained reads (drives failing read after write pointer)