OSDN Git Service

rocker: Remove getting PORT_BRIDGE_FLAGS
authorFlorian Fainelli <f.fainelli@gmail.com>
Mon, 11 Feb 2019 21:17:48 +0000 (13:17 -0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 12 Feb 2019 17:49:53 +0000 (12:49 -0500)
There is no code that attempts to get the
SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS attribute, remove support for that.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/rocker/rocker.h
drivers/net/ethernet/rocker/rocker_main.c
drivers/net/ethernet/rocker/rocker_ofdpa.c

index 748fb12..2b2e1c4 100644 (file)
@@ -109,8 +109,6 @@ struct rocker_world_ops {
        int (*port_attr_bridge_flags_set)(struct rocker_port *rocker_port,
                                          unsigned long brport_flags,
                                          struct switchdev_trans *trans);
-       int (*port_attr_bridge_flags_get)(const struct rocker_port *rocker_port,
-                                         unsigned long *p_brport_flags);
        int (*port_attr_bridge_flags_support_get)(const struct rocker_port *
                                                  rocker_port,
                                                  unsigned long *
index 66f72f8..5ce8d5a 100644 (file)
@@ -1583,17 +1583,6 @@ rocker_world_port_attr_bridge_flags_set(struct rocker_port *rocker_port,
 }
 
 static int
-rocker_world_port_attr_bridge_flags_get(const struct rocker_port *rocker_port,
-                                       unsigned long *p_brport_flags)
-{
-       struct rocker_world_ops *wops = rocker_port->rocker->wops;
-
-       if (!wops->port_attr_bridge_flags_get)
-               return -EOPNOTSUPP;
-       return wops->port_attr_bridge_flags_get(rocker_port, p_brport_flags);
-}
-
-static int
 rocker_world_port_attr_bridge_flags_support_get(const struct rocker_port *
                                                rocker_port,
                                                unsigned long *
@@ -2061,10 +2050,6 @@ static int rocker_port_attr_get(struct net_device *dev,
        int err = 0;
 
        switch (attr->id) {
-       case SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS:
-               err = rocker_world_port_attr_bridge_flags_get(rocker_port,
-                                                             &attr->u.brport_flags);
-               break;
        case SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS_SUPPORT:
                err = rocker_world_port_attr_bridge_flags_support_get(rocker_port,
                                                                      &attr->u.brport_flags_support);
index bea7895..9c07f60 100644 (file)
@@ -2512,16 +2512,6 @@ static int ofdpa_port_attr_bridge_flags_set(struct rocker_port *rocker_port,
 }
 
 static int
-ofdpa_port_attr_bridge_flags_get(const struct rocker_port *rocker_port,
-                                unsigned long *p_brport_flags)
-{
-       const struct ofdpa_port *ofdpa_port = rocker_port->wpriv;
-
-       *p_brport_flags = ofdpa_port->brport_flags;
-       return 0;
-}
-
-static int
 ofdpa_port_attr_bridge_flags_support_get(const struct rocker_port *
                                         rocker_port,
                                         unsigned long *