OSDN Git Service

net: stmmac: Fix error return code in ingenic_mac_probe()
authorWei Yongjun <weiyongjun1@huawei.com>
Tue, 15 Jun 2021 17:21:55 +0000 (17:21 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 16 Jun 2021 19:02:38 +0000 (12:02 -0700)
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 2bb4b98b60d7 ("net: stmmac: Add Ingenic SoCs MAC support.")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/dwmac-ingenic.c

index 60984c1..9a6d819 100644 (file)
@@ -263,6 +263,7 @@ static int ingenic_mac_probe(struct platform_device *pdev)
        mac->regmap = syscon_regmap_lookup_by_phandle(pdev->dev.of_node, "mode-reg");
        if (IS_ERR(mac->regmap)) {
                dev_err(&pdev->dev, "%s: Failed to get syscon regmap\n", __func__);
+               ret = PTR_ERR(mac->regmap);
                goto err_remove_config_dt;
        }