OSDN Git Service

ext4: add missing brelse() add_new_gdb_meta_bg()'s error path
authorVasily Averin <vvs@virtuozzo.com>
Sat, 3 Nov 2018 20:50:08 +0000 (16:50 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Sat, 3 Nov 2018 20:50:08 +0000 (16:50 -0400)
Fixes: 01f795f9e0d6 ("ext4: add online resizing support for meta_bg ...")
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org # 3.7
fs/ext4/resize.c

index 0a4dc62..7131f35 100644 (file)
@@ -922,6 +922,7 @@ static int add_new_gdb_meta_bg(struct super_block *sb,
                                     sizeof(struct buffer_head *),
                                     GFP_NOFS);
        if (!n_group_desc) {
+               brelse(gdb_bh);
                err = -ENOMEM;
                ext4_warning(sb, "not enough memory for %lu groups",
                             gdb_num + 1);
@@ -937,8 +938,6 @@ static int add_new_gdb_meta_bg(struct super_block *sb,
        kvfree(o_group_desc);
        BUFFER_TRACE(gdb_bh, "get_write_access");
        err = ext4_journal_get_write_access(handle, gdb_bh);
-       if (unlikely(err))
-               brelse(gdb_bh);
        return err;
 }