OSDN Git Service

ASoC: sigmadsp: Fix missleading return value
authorPascal Huerst <pascal.huerst@gmail.com>
Wed, 10 Feb 2016 14:59:28 +0000 (15:59 +0100)
committerMark Brown <broonie@kernel.org>
Wed, 10 Feb 2016 18:55:01 +0000 (18:55 +0000)
Forwarding the return value of i2c_master_send, leads to errors
later on, since i2c_master_send returns the number of bytes
transmittet. Check for ret < 0 instead and return 0 otherwise.

Signed-off-by: Pascal Huerst <pascal.huerst@gmail.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/sigmadsp-i2c.c

index 21ca3a5..d374c18 100644 (file)
@@ -31,7 +31,10 @@ static int sigmadsp_write_i2c(void *control_data,
 
        kfree(buf);
 
-       return ret;
+       if (ret < 0)
+               return ret;
+
+       return 0;
 }
 
 static int sigmadsp_read_i2c(void *control_data,