Move a few FIXME to a separate to-do list

And delete a few FIXME that are obsolete.

Change-Id: Ibc65c26e75f9e9ace81d264760f93384a7fc71a5

diff --git a/opensles/libopensles/IEngine.c b/opensles/libopensles/IEngine.c
index 521e487..196e6d9 100644 (file)
--- a/opensles/libopensles/IEngine.c
+++ b/opensles/libopensles/IEngine.c
@@ -240,7 +240,6 @@ static SLresult IEngine_CreateAudioPlayer(SLEngineItf self, SLObjectItf *pPlayer
                     }
 #endif
 
-                    // FIXME move to dedicated function
                     // Allocate memory for buffer queue
 
                     //if (0 != this->mBufferQueue.mNumBuffers) {
@@ -462,7 +461,7 @@ static SLresult IEngine_CreateMidiPlayer(SLEngineItf self, SLObjectItf *pPlayer,
                 "pVibra", pVibra, NULL | IODEVICE, NULL
                 "pLEDArray", pLEDArray, NULL | IODEVICE, NULL
 #endif
-                // FIXME a fake value - why not use value from IPlay_init? what does CT check for?
+                // a fake value - why not use value from IPlay_init? what does CT check for?
                 this->mPlay.mDuration = 0;
                 IObject_Publish(&this->mObject);
                 // return the new MIDI player object
@@ -1120,7 +1119,6 @@ static XAresult IEngine_GetImplementationInfo(XAEngineItf self, XAuint32 *pMajor
 
     //IXAEngine *this = (IXAEngine *) self;
     result = SL_RESULT_FEATURE_UNSUPPORTED;
-    // FIXME
 
     XA_LEAVE_INTERFACE
 }
@@ -1134,9 +1132,8 @@ static XAresult IXAEngine_QuerySupportedProfiles(XAEngineItf self, XAint16 *pPro
         result = XA_RESULT_PARAMETER_INVALID;
     } else {
 #if 1
-        // FIXME
         *pProfilesSupported = 0;
-        // FIXME the code below was copied from OpenSL ES and needs to be adapted for OpenMAX AL.
+        // the code below was copied from OpenSL ES and needs to be adapted for OpenMAX AL.
 #else
         // The generic implementation doesn't implement any of the profiles, they shouldn't be
         // declared as supported. Also exclude the fake profiles BASE and OPTIONAL.

diff --git a/opensles/libopensles/IOutputMix.c b/opensles/libopensles/IOutputMix.c
index 7cef8f4..2b1c30e 100644 (file)
--- a/opensles/libopensles/IOutputMix.c
+++ b/opensles/libopensles/IOutputMix.c
@@ -70,10 +70,6 @@ static SLresult IOutputMix_ReRoute(SLOutputMixItf self, SLint32 numOutputDevices
     } else {
         switch (pOutputDeviceIDs[0]) {
         case SL_DEFAULTDEVICEID_AUDIOOUTPUT:
-#if 0 // FIXME These OEM-specific constants should be configurable
-        case DEVICE_ID_HEADSET:
-        case DEVICE_ID_HANDSFREE:
-#endif
             result = SL_RESULT_SUCCESS;
             break;
         default:

diff --git a/opensles/libopensles/data.c b/opensles/libopensles/data.c
index 10bb20a..83ae74d 100644 (file)
--- a/opensles/libopensles/data.c
+++ b/opensles/libopensles/data.c
@@ -97,7 +97,6 @@ static SLresult checkDataLocator(const char *name, void *pLocator, DataLocator *
                         SL_LOGE("%s: locatorType=IODEVICE, but device field %p has wrong " \
                             "object ID or is not realized", name, device);
                         pDataLocator->mIODevice.device = NULL;
-                        // FIXME return result;
                     }
                 }
             } else {
@@ -166,7 +165,6 @@ static SLresult checkDataLocator(const char *name, void *pLocator, DataLocator *
                     "not refer to an SL_OBJECTID_OUTPUTMIX or the output mix is not realized", \
                     name, pDataLocator->mOutputMix.outputMix);
                 pDataLocator->mOutputMix.outputMix = NULL;
-                // FIXME return result;
             }
             break;
 

diff --git a/opensles/libopensles/sles.c b/opensles/libopensles/sles.c
index d793022..e4a9776 100644 (file)
--- a/opensles/libopensles/sles.c
+++ b/opensles/libopensles/sles.c
@@ -54,7 +54,7 @@ bool IsInterfaceInitialized(IObject *this, unsigned MPH)
 SLuint32 IObjectToObjectID(IObject *this)
 {
     assert(NULL != this);
-    // FIXME Note this returns the SLES object ID in preference to the OMX AL if both available
+    // Note this returns the OpenSL ES object ID in preference to the OpenMAX AL if both available
     const ClassTable *class__ = this->mClass;
     assert(NULL != class__);
     SLuint32 id = class__->mSLObjectID;